Messages in this thread | | | From | Bhupesh Sharma <> | Date | Tue, 15 Jun 2021 22:30:39 +0530 | Subject | Re: [PATCH v2 10/10] arm64: dts: qcom: sa8155p-adp: Add base dts file |
| |
Hi Konrad,
Thanks for the review.
On Tue, 15 Jun 2021 at 20:23, Konrad Dybcio <konrad.dybcio@somainline.org> wrote: > > Hi, > > > > + > > + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>; > > + > > + vcc-supply = <&vreg_l10a_2p96>; > > + vcc-max-microamp = <750000>; > > + vccq-supply = <&vreg_l5c_1p2>; > > + vccq-max-microamp = <700000>; > > + vccq2-supply = <&vreg_s4a_1p8>; > > + vccq2-max-microamp = <750000>; > > You need to add "regulator-allow-set-load;" to the mentioned supplies, > > as you're controlling the amperage here.
Ok, I will fix this in v3.
> > +}; > > + > > +&ufs_mem_phy { > > + status = "okay"; > > + > > + vdda-phy-supply = <&vreg_l8c_1p2>; > > + vdda-max-microamp = <87100>; > > + vdda-pll-supply = <&vreg_l5a_0p88>; > > + vdda-pll-max-microamp = <18300>; > > Ditto
Sure, I will fix it in v3.
Thanks, Bhupesh
| |