Messages in this thread | | | Date | Mon, 14 Jun 2021 09:10:12 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH 2/3] kthread: Prevent deadlock when kthread_mod_delayed_work() races with kthread_cancel_delayed_work_sync() |
| |
On Fri 2021-06-11 13:41:25, Andrew Morton wrote: > On Fri, 11 Jun 2021 09:16:52 +0200 Petr Mladek <pmladek@suse.com> wrote: > > > On Thu 2021-06-10 14:30:30, Andrew Morton wrote: > > > On Thu, 10 Jun 2021 15:30:50 +0200 Petr Mladek <pmladek@suse.com> wrote: > > > > > > > The system might hang with the following backtrace: > > > > > > Well that's not good. > > > > Fortunately, the API users normally synchronize these operations > > another way. The race should never happen when the API is used > > a reasonable way, > > see https://lore.kernel.org/lkml/YKZLnTNOlUQ85F2s@alley/ > > > > > > Fixes: 9a6b06c8d9a220860468a ("kthread: allow to modify delayed kthread work") > > > > Reported-by: Martin Liu <liumartin@google.com> > > > > Signed-off-by: Petr Mladek <pmladek@suse.com> > > > > > > Was a -stable backport considered? > > > > Good point! It would make sense to backport it. System hang is never > > good. > > > > Could you please add Cc: stable@vger.kernel.org or should I resend the > > patchset? > > I made that change to patches 1&2. I don't think patch 3 need be > backported?
Sounds good to me. Thanks a lot for the update.
Best Regards, Petr
| |