lkml.org 
[lkml]   [2021]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 62/67] NFSv4: nfs4_proc_set_acl needs to restore NFS_CAP_UIDGID_NOMAP on error.
    Date
    From: Dai Ngo <dai.ngo@oracle.com>

    commit f8849e206ef52b584cd9227255f4724f0cc900bb upstream.

    Currently if __nfs4_proc_set_acl fails with NFS4ERR_BADOWNER it
    re-enables the idmapper by clearing NFS_CAP_UIDGID_NOMAP before
    retrying again. The NFS_CAP_UIDGID_NOMAP remains cleared even if
    the retry fails. This causes problem for subsequent setattr
    requests for v4 server that does not have idmapping configured.

    This patch modifies nfs4_proc_set_acl to detect NFS4ERR_BADOWNER
    and NFS4ERR_BADNAME and skips the retry, since the kernel isn't
    involved in encoding the ACEs, and return -EINVAL.

    Steps to reproduce the problem:

    # mount -o vers=4.1,sec=sys server:/export/test /tmp/mnt
    # touch /tmp/mnt/file1
    # chown 99 /tmp/mnt/file1
    # nfs4_setfacl -a A::unknown.user@xyz.com:wrtncy /tmp/mnt/file1
    Failed setxattr operation: Invalid argument
    # chown 99 /tmp/mnt/file1
    chown: changing ownership of ‘/tmp/mnt/file1’: Invalid argument
    # umount /tmp/mnt
    # mount -o vers=4.1,sec=sys server:/export/test /tmp/mnt
    # chown 99 /tmp/mnt/file1
    #

    v2: detect NFS4ERR_BADOWNER and NFS4ERR_BADNAME and skip retry
    in nfs4_proc_set_acl.
    Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
    Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/nfs/nfs4proc.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    --- a/fs/nfs/nfs4proc.c
    +++ b/fs/nfs/nfs4proc.c
    @@ -5580,6 +5580,14 @@ static int nfs4_proc_set_acl(struct inod
    do {
    err = __nfs4_proc_set_acl(inode, buf, buflen);
    trace_nfs4_set_acl(inode, err);
    + if (err == -NFS4ERR_BADOWNER || err == -NFS4ERR_BADNAME) {
    + /*
    + * no need to retry since the kernel
    + * isn't involved in encoding the ACEs.
    + */
    + err = -EINVAL;
    + break;
    + }
    err = nfs4_handle_exception(NFS_SERVER(inode), err,
    &exception);
    } while (exception.retry);

    \
     
     \ /
      Last update: 2021-06-14 12:51    [W:4.209 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site