lkml.org 
[lkml]   [2021]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 27/49] USB: f_ncm: ncm_bitrate (speed) is unsigned
    Date
    From: Maciej Żenczykowski <maze@google.com>

    commit 3370139745853f7826895293e8ac3aec1430508e upstream.

    [ 190.544755] configfs-gadget gadget: notify speed -44967296

    This is because 4250000000 - 2**32 is -44967296.

    Fixes: 9f6ce4240a2b ("usb: gadget: f_ncm.c added")
    Cc: Brooke Basile <brookebasile@gmail.com>
    Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
    Cc: Felipe Balbi <balbi@kernel.org>
    Cc: Lorenzo Colitti <lorenzo@google.com>
    Cc: Yauheni Kaliuta <yauheni.kaliuta@nokia.com>
    Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>
    Acked-By: Lorenzo Colitti <lorenzo@google.com>
    Signed-off-by: Maciej Żenczykowski <maze@google.com>
    Cc: stable <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20210608005344.3762668-1-zenczykowski@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/gadget/function/f_ncm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/gadget/function/f_ncm.c
    +++ b/drivers/usb/gadget/function/f_ncm.c
    @@ -589,7 +589,7 @@ static void ncm_do_notify(struct f_ncm *
    data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));
    data[1] = data[0];

    - DBG(cdev, "notify speed %d\n", ncm_bitrate(cdev->gadget));
    + DBG(cdev, "notify speed %u\n", ncm_bitrate(cdev->gadget));
    ncm->notify_state = NCM_NOTIFY_CONNECT;
    break;
    }

    \
     
     \ /
      Last update: 2021-06-14 12:44    [W:4.052 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site