lkml.org 
[lkml]   [2021]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][next] Input: Fix fall-through warning for Clang
Hi Joe,

On Mon, Jun 07, 2021 at 03:02:40PM -0700, Joe Perches wrote:
> On Mon, 2021-06-07 at 16:48 -0500, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> > warning by explicitly adding a fallthrough; statement.
> []
> > diff --git a/drivers/input/joystick/sidewinder.c b/drivers/input/joystick/sidewinder.c
> []
> > @@ -660,6 +660,7 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv)
> >   fallthrough;
> >   case 45: /* Ambiguous packet length */
> >   if (j <= 40) { /* ID length less or eq 40 -> FSP */
> > + fallthrough;
> >   case 43:
> >   sw->type = SW_ID_FSP;
> >   break;
>
> Yuck. Super ugly. There's no need to play games with indentation.

Yeah, the original code is not pretty :(

>
> Perhaps the simpler:
>
> case 43:
> sw->type = SW_ID_FSP;
> break;
> case 45: /* Ambiguous packet length */
> if (j <= 40) { /* ID length less or eq 40 -> FSP */
> sw->type = SW_ID_FSP;
> break;
> }
> sw->number++;
> fallthrough;
>
>

Could you resubmit this version properly formatted?

Thanks.

--
Dmitry

\
 
 \ /
  Last update: 2021-06-15 00:13    [W:0.045 / U:2.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site