lkml.org 
[lkml]   [2021]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pstore/blk: Use the normal block device I/O path
On Mon, Jun 14, 2021 at 01:04:21PM -0700, Kees Cook wrote:

> static ssize_t psblk_generic_blk_write(const char *buf, size_t bytes,
> loff_t pos)
> {

> /* Console/Ftrace backend may handle buffer until flush dirty zones */
> if (in_interrupt() || irqs_disabled())
> return -EBUSY;

> + return kernel_write(psblk_file, buf, bytes, &pos);

In which locking environments could that be called? The checks above
look like that thing could be called from just about any context;
could that happen when the caller is holding a page locked?

IOW, what are those checks really trying to do?

\
 
 \ /
  Last update: 2021-06-14 22:11    [W:0.044 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site