Messages in this thread | | | Subject | Re: [PATCH] ath10k: Fix an error code in ath10k_add_interface() | From | Kalle Valo <> | Date | Mon, 14 Jun 2021 15:40:48 +0000 (UTC) |
| |
Yang Li <yang.lee@linux.alibaba.com> wrote:
> When the code execute this if statement, the value of ret is 0. > However, we can see from the ath10k_warn() log that the value of > ret should be -EINVAL. > > Clean up smatch warning: > > drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn: > missing error code 'ret' > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Fixes: 'commit ccec9038c721 ("ath10k: enable raw encap mode and software > crypto engine")' > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Fixes tag is wrong, it should be:
Fixes: ccec9038c721 ("ath10k: enable raw encap mode and software crypto engine")
I fixed this in the pending branch, no need to resend because of this.
-- https://patchwork.kernel.org/project/linux-wireless/patch/1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |