lkml.org 
[lkml]   [2021]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] afs: Fix afs_write_end() to handle short writes
On Mon, Jun 14, 2021 at 02:20:25PM +0100, David Howells wrote:
> @@ -135,8 +145,6 @@ int afs_write_end(struct file *file, struct address_space *mapping,
> write_sequnlock(&vnode->cb_lock);
> }
>
> - ASSERT(PageUptodate(page));
> -
> if (PagePrivate(page)) {
> priv = page_private(page);
> f = afs_page_dirty_from(page, priv);

Why are you removing this assertion? Does AFS now support dirty,
partially-uptodate pages? If so, a subsequent read() to that
page is going to need to be careful to only read the parts of the page
from the server that haven't been written ...

\
 
 \ /
  Last update: 2021-06-14 16:40    [W:0.202 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site