Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Sat, 12 Jun 2021 11:18:09 +0200 | Subject | Re: [PATCH 1/1] ep93xx: clock: convert in-place to COMMON_CLK |
| |
Hi Alexander,
On Sat, Jun 12, 2021 at 12:42 AM Alexander Sverdlin <alexander.sverdlin@gmail.com> wrote: > On Tue, 2021-05-25 at 11:33 +0300, Nikita Shubin wrote: > > Converted in-place without moving file to drivers/clk. > > > > tested on ts7250 (EP9302). > > > > Only setting rate and change parent tested for, as they > > are missing on ts7250: > > - video > > - I2S > > - ADC/KEYPAD > > - PWM > > > > Only video and I2S clock are interesting, as they are > > GATE + double DIV + MUX, all other are pretty much > > common but require ep93xx_syscon_swlocked_write to set > > registers. > > This doesnt look good in my test: > > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:1011 clk_core_enable+0x9c/0xbc > Enabling unprepared ep93xx-adc
> [<c0266560>] (ep93xx_adc_probe) from [<c02126e0>] (platform_probe+0x34/0x80)
> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:1011 clk_core_enable+0x9c/0xbc > Enabling unprepared ep93xx-spi.0
> [<c023eeb4>] (ep93xx_spi_prepare_hardware) from [<c023c0f8>] (__spi_pump_messages+0x124/0x620)
> WARNING: CPU: 0 PID: 36 at drivers/clk/clk.c:952 clk_core_disable+0xbc/0xd8 > ep93xx-spi.0 already disabled > [<c023ee98>] (ep93xx_spi_unprepare_hardware) from [<c023c35c>] (__spi_pump_messages+0x388/0x620)
These are issues in individual drivers, not in the CCF implementation. All drivers using the clock API should be converted from clk_{en,dis}able() to clk_{prepare_enable,disable_unprepare}() first.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |