Messages in this thread | | | From | Bill Wendling <> | Date | Sat, 12 Jun 2021 15:47:56 -0700 | Subject | Re: [PATCH v9] pgo: add clang's Profile Guided Optimization infrastructure |
| |
On Sat, Jun 12, 2021 at 1:56 PM Bill Wendling <morbo@google.com> wrote: > On Sat, Jun 12, 2021 at 1:25 PM Peter Zijlstra <peterz@infradead.org> wrote: > > On Sat, Jun 12, 2021 at 12:10:03PM -0700, Bill Wendling wrote: > > Yes it is, but is that sufficient in this case? It very much isn't for > > KASAN, UBSAN, and a whole host of other instrumentation crud. They all > > needed their own 'bugger-off' attributes. > > > Now, for the "nointr" issue. I'll see if we need an additional change for that. > The GCOV implementation disables profiling in those directories where instrumentation would fail. We do the same. Both clang and gcc seem to treat the no_instrument_function attribute similarly.
-bw
| |