lkml.org 
[lkml]   [2021]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/3] dt-bindings: iommu: add DART iommu bindings
Hi,

On Thu, Jun 10, 2021, at 18:52, Rob Herring wrote:
> On Thu, Jun 03, 2021 at 10:50:02AM +0200, Sven Peter wrote:
> > +
> > +examples:
> > + - |+
> > + dart1: iommu@82f80000 {
> > + compatible = "apple,t8103-dart";
> > + reg = <0x82f80000 0x4000>;
> > + interrupts = <1 781 4>;
> > + #iommu-cells = <1>;
> > + };
> > +
> > + master1 {
> > + iommus = <&{/dart1} 0>;
>
> /dart1 is a path, but 'dart1' is a label. You need '&dart1' (or
> '&{/iommu@82f80000}' but that doesn't really work here because the
> examples get prefixed with /example-n/...)
>
> With that fixed,
>
> Reviewed-by: Rob Herring <robh@kernel.org>

Makes sense, thanks for the review!
Fixed for the next version.


Sven

\
 
 \ /
  Last update: 2021-06-12 14:26    [W:0.055 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site