Messages in this thread | | | Date | Fri, 11 Jun 2021 08:53:38 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 09/16] ps3disk: use memcpy_{from,to}_bvec |
| |
On Tue, Jun 08, 2021 at 06:48:22PM -0700, Ira Weiny wrote: > I'm still not 100% sure that these flushes are needed but the are not no-ops on > every arch. Would it be best to preserve them after the memcpy_to/from_bvec()? > > Same thing in patch 11 and 14.
To me it seems kunmap_local should basically always call the equivalent of flush_kernel_dcache_page. parisc does this through kunmap_flush_on_unmap, but none of the other architectures with VIVT caches or other coherency issues does.
Does anyone have a history or other insights here?
| |