Messages in this thread | | | Subject | Re: [PATCH 1/2] memory: tegra: Add missing dependencies | From | Krzysztof Kozlowski <> | Date | Fri, 11 Jun 2021 08:50:39 +0200 |
| |
On 10/06/2021 18:23, Dmitry Osipenko wrote: > 10.06.2021 18:50, Dmitry Osipenko пишет: >> 10.06.2021 09:43, Krzysztof Kozlowski пишет: >>> The stubs might be good idea anyway, but the driver explicitly needs for >>> runtime working reservedmem, so it should select it. >> >> The OF and reservedmem are both selected by the ARCH for the runtime >> use. They may not be selected in the case of compile-testing. >> >> Both OF core and reservedmem provide stubs needed for compile-testing, >> it's only the RESERVEDMEM_OF_DECLARE() that is missing the stub. Adding >> the missing stub should be a more appropriate solution than adding extra >> Kconfig dependencies, IMO.
Ah, in such case everything looks good. Stubs is indeed proper choice.
> I will send the patch. If OF maintainers will have objections, then > adding the dependency may become a more reasonable option.
Thanks!
Best regards, Krzysztof
| |