Messages in this thread | | | Date | Fri, 11 Jun 2021 17:35:50 +0200 | From | Martin Kaiser <> | Subject | Re: [PATCH 0/6] staging: rtl8188eu: remove hal/odm_debug.h |
| |
Thus wrote Dan Carpenter (dan.carpenter@oracle.com):
> On Fri, Jun 11, 2021 at 01:24:58AM +0100, Phillip Potter wrote: > > This series removes hal/odm_debug.h, which contains various preprocessor > > definitions, as well as an unwieldy ODM_RT_TRACE macro which is not best > > practice. It also removes all uses of this macro, and the associated > > fields in struct odm_dm_struct which are only used by this macro.
> > This makes the code cleaner, thus moving it closer to getting out of > > staging.
> Looks good.
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
same here: looks ok and doesn't break anything
Reviewed-by: Martin Kaiser <martin@kaiser.cx> Tested-by: Martin Kaiser <martin@kaiser.cx>
Best regards,
Martin
| |