Messages in this thread | | | Subject | Re: [PATCH 4/9] nvmem: sprd: Fix an error message | From | Srinivas Kandagatla <> | Date | Fri, 11 Jun 2021 10:05:40 +0100 |
| |
On 11/06/2021 09:56, Greg KH wrote: > On Fri, Jun 11, 2021 at 09:33:43AM +0100, Srinivas Kandagatla wrote: >> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> >> >> 'ret' is known to be 0 here. >> The expected error status is stored in 'status', so use it instead. >> >> Also change %d in %u, because status is an u32, not a int. >> >> Fixes: 096030e7f449 ("nvmem: sprd: Add Spreadtrum SoCs eFuse support") >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> >> Acked-by: Chunyan Zhang <zhang.lyra@gmail.com> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> drivers/nvmem/sprd-efuse.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/nvmem/sprd-efuse.c b/drivers/nvmem/sprd-efuse.c >> index 5d394559edf2..e3e721d4c205 100644 >> --- a/drivers/nvmem/sprd-efuse.c >> +++ b/drivers/nvmem/sprd-efuse.c >> @@ -234,7 +234,7 @@ static int sprd_efuse_raw_prog(struct sprd_efuse *efuse, u32 blk, bool doub, >> status = readl(efuse->base + SPRD_EFUSE_ERR_FLAG); >> if (status) { >> dev_err(efuse->dev, >> - "write error status %d of block %d\n", ret, blk); >> + "write error status %u of block %d\n", status, blk); > > Shouldn't this be %pe and not %u?
This is not error pointer its status value read back from a register.
I think %u should be good here.
--srini > > thanks, > > greg k-h >
| |