Messages in this thread | | | From | Dan Williams <> | Date | Fri, 11 Jun 2021 17:16:55 -0700 | Subject | Re: [PATCH 4/5] libnvdimm: Drop unused device power management support |
| |
On Fri, Jun 11, 2021 at 4:47 AM Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote: > > On Thu, 10 Jun 2021 15:26:19 -0700 > Dan Williams <dan.j.williams@intel.com> wrote: > > > LIBNVDIMM device objects register sysfs power attributes despite nothing > > requiring that support. Clean up sysfs remove the power/ attribute > > group. This requires a device_create() and a device_register() usage to > > be converted to the device_initialize() + device_add() pattern. > > > > Signed-off-by: Dan Williams <dan.j.williams@intel.com> > Trivial comment below. Looks good. > > > --- > > drivers/nvdimm/bus.c | 45 +++++++++++++++++++++++++++++++++++++-------- > > 1 file changed, 37 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c > > index a11821df83b5..e6aa87043a95 100644 > > --- a/drivers/nvdimm/bus.c > > +++ b/drivers/nvdimm/bus.c > > @@ -363,8 +363,13 @@ struct nvdimm_bus *nvdimm_bus_register(struct device *parent, > > nvdimm_bus->dev.groups = nd_desc->attr_groups; > > nvdimm_bus->dev.bus = &nvdimm_bus_type; > > nvdimm_bus->dev.of_node = nd_desc->of_node; > > - dev_set_name(&nvdimm_bus->dev, "ndbus%d", nvdimm_bus->id); > > - rc = device_register(&nvdimm_bus->dev); > > + device_initialize(&nvdimm_bus->dev); > > + device_set_pm_not_required(&nvdimm_bus->dev); > > + rc = dev_set_name(&nvdimm_bus->dev, "ndbus%d", nvdimm_bus->id); > > + if (rc) > > + goto err; > > Maybe mention in patch description that you also now handle errors in > dev_set_name()?
Yeah, that's a philosophy change from when this code was first written.
| |