lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v9 02/22] media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL
    Hi Ricardo,

    Thank you for the patch.

    On Fri, Mar 26, 2021 at 10:58:20AM +0100, Ricardo Ribalda wrote:
    > The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is
    > written.
    >
    > Cc: Mike Isely <isely@pobox.com>
    > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
    > Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    > ---
    > drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 ----
    > 1 file changed, 4 deletions(-)
    >
    > diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
    > index 9657c1883311..c04ab7258d64 100644
    > --- a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
    > +++ b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
    > @@ -640,10 +640,6 @@ static int pvr2_s_ext_ctrls(struct file *file, void *priv,
    > unsigned int idx;
    > int ret;
    >
    > - /* Default value cannot be changed */
    > - if (ctls->which == V4L2_CTRL_WHICH_DEF_VAL)
    > - return -EINVAL;
    > -
    > ret = 0;
    > for (idx = 0; idx < ctls->count; idx++) {
    > ctrl = ctls->controls + idx;

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2021-06-10 19:30    [W:3.461 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site