Messages in this thread | | | Date | Thu, 10 Jun 2021 09:52:25 -0600 | From | Mathieu Poirier <> | Subject | Re: [PATCH v5 1/1] perf cs-etm: Split Coresight decode by aux records |
| |
On Thu, Jun 10, 2021 at 04:55:27PM +0300, James Clark wrote: > > > On 10/06/2021 13:36, James Clark wrote: > > + return auxtrace_queues__add_event(&etm->queues, > > + session, > > + &auxtrace_fragment, > > + file_offset, > > + NULL); > > There's one more indentation error here that I will fix in the next set.
Yes, this one needs fixing and while at it you probably want to fix the stacking as well:
return auxtrace_queues__add_event(&etm->queues, session, &auxtrace_fragment, file_offset, NULL);
Also look for "deccoding" at the end of the second paragraph in the changelog.
Thanks, Mathieu
| |