lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] iio: core: Support removing extended name in attribute filename
Hi Andy,

Le jeu., juin 10 2021 at 15:58:51 +0300, Andy Shevchenko
<andy.shevchenko@gmail.com> a écrit :
> On Thu, Jun 10, 2021 at 3:47 PM Paul Cercueil <paul@crapouillou.net>
> wrote:
>>
>> By default, when a channel has an extended name, it will appear in
>> the
>> filename of channel attributes. E.g. if the extended name is "aux",
>> the
>> filename of a "sample_rate" attribute will be something like:
>> in_voltage0_aux_sample_rate
>>
>> Add a mechanism to disable this feature. This will be used to add a
>> "extended_name" channel attribute.
>
> I'm afraid, NAK. Otherwise, please put an explanation that clearly
> shows that it will be no ABI breakage.
> I.o.w. users for the existing drivers and devices will always get
> those attributes at the same platform configuration(s).

Well, the commit message says that I'm adding a mechanism to disable
the feature. If it was actually doing anything else (like actually
disabling it for any attribute) then I'd mention it in the commit
message.

I don't see how that possibly can be a ABI breakage.

-Paul


\
 
 \ /
  Last update: 2021-06-10 15:06    [W:0.371 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site