Messages in this thread | | | Subject | Re: [PATCH] powerpc/vdso: Fix multiple issues with sys_call_table | From | Christophe Leroy <> | Date | Thu, 10 Jun 2021 13:36:03 +0200 |
| |
Le 19/03/2020 à 02:10, Michael Ellerman a écrit : > Anton Blanchard <anton@ozlabs.org> writes: >> The VDSO exports a bitmap of valid syscalls. vdso_setup_syscall_map() >> sets this up, but there are both little and big endian bugs. The issue >> is with: >> >> if (sys_call_table[i] != sys_ni_syscall) >> >> On little endian, instead of comparing pointers to the two functions, >> we compare the first two instructions of each function. If a function >> happens to have the same first two instructions as sys_ni_syscall, then >> we have a spurious match and mark the instruction as not implemented. >> Fix this by removing the inline declarations. >> >> On big endian we have a further issue where sys_ni_syscall is a function >> descriptor and sys_call_table[] holds pointers to the instruction text. >> Fix this by using dereference_kernel_function_descriptor(). >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Anton Blanchard <anton@ozlabs.org> > > That's some pretty epic breakage. > > Is it even worth keeping, or should we just rip it out and declare that > the syscall map is junk? Userspace can hardly rely on it given it's been > this broken for so long. > > If not it would be really nice to have a selftest of this stuff so we > can verify it works and not break it again in future. >
The problem on little endian is fixed by https://github.com/linuxppc/linux/commit/bc9d5bfc4 I think.
On big endian, I can't see any problem. Looks like sys_call_table in a vmlinux generated with ppc64_defconfig contains addresses of items in the opd. So it should be ok, shoudln't it ?
[root@po9473vm linux-powerpc]# powerpc64-linux-objdump -x vmlinux | grep -e " sys_call_table" -e ni_syscall c000000000fc0748 g .rodata 0000000000000000 sys_call_table c00000000019fd90 g F .text 0000000000000028 .sys_ni_syscall c000000001cc3678 g F .opd 0000000000000018 sys_ni_syscall
[root@po9473vm linux-powerpc]# powerpc64-linux-objdump -s -j .rodata vmlinux Contents of section .rodata: ... c000000000fc0740 a610e9ee a3f43156 c0000000 01cc0888 ......1V........ c000000000fc0750 c0000000 01cbf5c8 c0000000 01cbe788 ................ c000000000fc0760 c0000000 01cf6768 c0000000 01cf6798 ......gh......g. c000000000fc0770 c0000000 01cf6240 c0000000 01cf5dd8 ......b@......]. c000000000fc0780 c0000000 01cbf670 c0000000 01cf61e0 .......p......a. c000000000fc0790 c0000000 01cf8490 c0000000 01cf8580 ................ c000000000fc07a0 c0000000 01cf7890 c0000000 01cf5e50 ......x.......^P c000000000fc07b0 c0000000 01ccf120 c0000000 01cf8358 ....... .......X c000000000fc07c0 c0000000 01cf6060 c0000000 01cf6108 ......``......a. c000000000fc07d0 c0000000 01cc3678 c0000000 01cc3678 ......6x......6x c000000000fc07e0 c0000000 01cf63a8 c0000000 01cc1680 ......c......... c000000000fc07f0 c0000000 01cfac50 c0000000 01cc3678 .......P......6x ...
Do you agree ?
Christophe
| |