lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/11] mm: page_vma_mapped_walk(): crossing page table boundary
    On Wed, Jun 09, 2021 at 11:44:10PM -0700, Hugh Dickins wrote:
    > page_vma_mapped_walk() cleanup: adjust the test for crossing page table
    > boundary - I believe pvmw->address is always page-aligned, but nothing
    > else here assumed that;

    Maybe we should just get it aligned instead? (PMD_SIZE - PAGE_SIZE) is not
    most obvious mask calculation.

    > and remember to reset pvmw->pte to NULL after
    > unmapping the page table, though I never saw any bug from that.

    Okay, it's fair enough.

    --
    Kirill A. Shutemov

    \
     
     \ /
      Last update: 2021-06-10 11:33    [W:3.785 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site