lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/8] pinctrl: qcom/pinctrl-spmi-gpio: Add compatibles for pmic-gpios on SA8155p-adp
    On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote:

    > SA8155p-adp PMICs (PMM8155AU_1 and PMM8155AU_2) expose
    > the following PMIC GPIO blocks:
    >
    > - PMM8155AU_1: gpio1-gpio10 (with holes on gpio2, gpio5, gpio7 and gpio8)
    > - PMM8155AU_2: gpio1-gpio10 (with holes on gpio2, gpio5, gpio7)
    >
    > Add support for the same in the pinctrl driver.
    >
    > Cc: Linus Walleij <linus.walleij@linaro.org>
    > Cc: Liam Girdwood <lgirdwood@gmail.com>
    > Cc: Mark Brown <broonie@kernel.org>
    > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
    > Cc: Vinod Koul <vkoul@kernel.org>
    > Cc: Rob Herring <robh+dt@kernel.org>
    > Cc: Andy Gross <agross@kernel.org>
    > Cc: devicetree@vger.kernel.org
    > Cc: linux-kernel@vger.kernel.org
    > Cc: linux-gpio@vger.kernel.org
    > Cc: bhupesh.linux@gmail.com
    > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
    > ---
    > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 4 ++++
    > 1 file changed, 4 insertions(+)
    >
    > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
    > index 00870da0c94e..890c44b6e198 100644
    > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
    > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
    > @@ -1127,6 +1127,10 @@ static const struct of_device_id pmic_gpio_of_match[] = {
    > { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
    > /* pm8150l has 12 GPIOs with holes on 7 */
    > { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
    > + /* pmm8155au-1 has 10 GPIOs with holes on 2, 5, 7 and 8 */
    > + { .compatible = "qcom,pmm8155au-1-gpio", .data = (void *) 10 },

    As noted in the binding, I think this should be "qcom,pmm8155au-gpio"
    and please skip the comment about the holes.

    Thanks,
    Bjorn

    > + /* pmm8155au-2 has 10 GPIOs with holes on 2, 5 and 7 */
    > + { .compatible = "qcom,pmm8155au-2-gpio", .data = (void *) 10 },
    > { .compatible = "qcom,pm8350-gpio", .data = (void *) 10 },
    > { .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
    > { .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
    > --
    > 2.31.1
    >

    \
     
     \ /
      Last update: 2021-06-11 05:01    [W:5.150 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site