lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] crypto: remove CRYPTOA_U32 and related functions
On Sat, Jun 05, 2021 at 01:39:02PM +0800, Liu Shixin wrote:
> According to the advice of Eric and Herbert, type CRYPTOA_U32
> has been unused for over a decade, so remove the code related to
> CRYPTOA_U32.
>
> After removing CRYPTOA_U32, the type of the variable attrs can be
> changed from union to struct.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> crypto/algapi.c | 18 ------------------
> crypto/algboss.c | 32 +++++++-------------------------
> include/crypto/algapi.h | 1 -
> include/linux/crypto.h | 5 -----
> 4 files changed, 7 insertions(+), 49 deletions(-)

Reviewed-by: Eric Biggers <ebiggers@google.com>

One nit below:

> + param->attrs[i].attr.rta_len =
> + sizeof(param->attrs[i]);

These two lines can be joined into one.

- Eric

\
 
 \ /
  Last update: 2021-06-11 01:02    [W:0.031 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site