Messages in this thread | | | Date | Thu, 10 Jun 2021 16:00:46 -0700 | From | Eric Biggers <> | Subject | Re: [PATCH -next] crypto: remove CRYPTOA_U32 and related functions |
| |
On Sat, Jun 05, 2021 at 01:39:02PM +0800, Liu Shixin wrote: > According to the advice of Eric and Herbert, type CRYPTOA_U32 > has been unused for over a decade, so remove the code related to > CRYPTOA_U32. > > After removing CRYPTOA_U32, the type of the variable attrs can be > changed from union to struct. > > Signed-off-by: Liu Shixin <liushixin2@huawei.com> > --- > crypto/algapi.c | 18 ------------------ > crypto/algboss.c | 32 +++++++------------------------- > include/crypto/algapi.h | 1 - > include/linux/crypto.h | 5 ----- > 4 files changed, 7 insertions(+), 49 deletions(-)
Reviewed-by: Eric Biggers <ebiggers@google.com>
One nit below:
> + param->attrs[i].attr.rta_len = > + sizeof(param->attrs[i]);
These two lines can be joined into one.
- Eric
| |