Messages in this thread | | | Date | Fri, 11 Jun 2021 08:01:55 +1000 | From | Dave Chinner <> | Subject | Re: [PATCH] xfs: Fix 64-bit division on 32-bit in xlog_state_switch_iclogs() |
| |
On Thu, Jun 10, 2021 at 01:00:01PM +0200, Geert Uytterhoeven wrote: > On 32-bit (e.g. m68k): > > ERROR: modpost: "__udivdi3" [fs/xfs/xfs.ko] undefined! > > Fix this by using a uint32_t intermediate, like before. > > Reported-by: noreply@ellerman.id.au > Fixes: 7660a5b48fbef958 ("xfs: log stripe roundoff is a property of the log") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > Compile-tested only. > --- > fs/xfs/xfs_log.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
<sigh>
64 bit division on 32 bit platforms is still a problem in this day and age?
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Maybe we should just put "requires 64 bit kernel" on XFS these days...
-Dave. -- Dave Chinner david@fromorbit.com
| |