lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/Makefile: make -stack-alignment conditional on LLD < 13.0.0
From
Date
On 6/10/2021 1:16 PM, Tor Vic wrote:
>
>
> On 10.06.21 19:20, Nick Desaulniers wrote:
>> On Thu, Jun 10, 2021 at 2:28 AM <torvic9@mailbox.org> wrote:
>>>
>>> Since LLVM commit 3787ee4, the '-stack-alignment' flag has been dropped [1],
>>> leading to the following error message when building a LTO kernel with
>>> Clang-13 and LLD-13:
>>>
>>> ld.lld: error: -plugin-opt=-: ld.lld: Unknown command line argument
>>> '-stack-alignment=8'. Try 'ld.lld --help'
>>> ld.lld: Did you mean '--stackrealign=8'?
>>>
>>> It also appears that the '-code-model' flag is not necessary anymore starting
>>> with LLVM-9 [2].
>>>
>>> Drop '-code-model' and make '-stack-alignment' conditional on LLD < 13.0.0.
>>
>> Please include this additional context in v2:
>> ```
>> These flags were necessary because these flags were not encoded in the
>> IR properly, so the link would restart optimizations without them. Now
>> there are properly encoded in the IR, and these flags exposing
>> implementation details are no longer necessary.
>> ```
>> That way it doesn't sound like we're not using an 8B stack alignment
>> on x86; we very much are so; AMDGPU GPFs without it!
>>
>
> Will do so.
> Does this have to be a v2 (with a "changes from v1" info) or just a
> resend? It is based on mainline now and the line numbers have changed.

Yes, this should be a v2 because the commit message changed. It would be
considered a resend if nothing changed and the patch just needed to be
picked up rather than re-reviewed.

Cheers,
Nathan

\
 
 \ /
  Last update: 2021-06-10 22:41    [W:0.088 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site