Messages in this thread | | | From | Nick Desaulniers <> | Date | Tue, 1 Jun 2021 12:18:35 -0700 | Subject | Re: [PATCH 2/3] hexagon: Use common DISCARDS macro |
| |
On Thu, May 20, 2021 at 6:13 PM Nathan Chancellor <nathan@kernel.org> wrote: > > ld.lld warns that the '.modinfo' section is not currently handled: > > ld.lld: warning: kernel/built-in.a(workqueue.o):(.modinfo) is being placed in '.modinfo' > ld.lld: warning: kernel/built-in.a(printk/printk.o):(.modinfo) is being placed in '.modinfo' > ld.lld: warning: kernel/built-in.a(irq/spurious.o):(.modinfo) is being placed in '.modinfo' > ld.lld: warning: kernel/built-in.a(rcu/update.o):(.modinfo) is being placed in '.modinfo' > > The '.modinfo' section was added in commit 898490c010b5 ("moduleparam: > Save information about built-in modules in separate file") to the > DISCARDS macro but Hexagon has never used that macro. The unification of > DISCARDS happened in commit 023bf6f1b8bf ("linker script: unify usage of > discard definition") in 2009, prior to Hexagon being added in 2011. > > Switch Hexagon over to the DISCARDS macro so that anything that is > expected to be discarded gets discarded. > > Fixes: e95bf452a9e2 ("Hexagon: Add configuration and makefiles for the Hexagon architecture.") > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Thanks for the patch. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> --- > arch/hexagon/kernel/vmlinux.lds.S | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/arch/hexagon/kernel/vmlinux.lds.S b/arch/hexagon/kernel/vmlinux.lds.S > index 20f19539c5fc..57465bff1fe4 100644 > --- a/arch/hexagon/kernel/vmlinux.lds.S > +++ b/arch/hexagon/kernel/vmlinux.lds.S > @@ -61,14 +61,9 @@ SECTIONS > > _end = .; > > - /DISCARD/ : { > - EXIT_TEXT > - EXIT_DATA > - EXIT_CALL > - } > - > STABS_DEBUG > DWARF_DEBUG > ELF_DETAILS > > + DISCARDS > } > -- > 2.32.0.rc0 >
-- Thanks, ~Nick Desaulniers
| |