Messages in this thread | | | From | Stephen Boyd <> | Subject | [PATCH v3 0/4] slub: Print non-hashed pointers in slub debugging | Date | Tue, 1 Jun 2021 11:21:58 -0700 |
| |
I was doing some debugging recently and noticed that my pointers were being hashed while slub_debug was on the kernel commandline. Let's force on the no hash pointer option when slub_debug is on the kernel commandline so that the prints are more meaningful.
The first two patches are something else I noticed while looking at the code. The message argument is never used so the debugging messages are not as clear as they could be and the slub_debug=- behavior seems to be busted. Then there's a printf fixup from Joe and the final patch is the one that force disables pointer hashing.
Changes from v2 (https://lore.kernel.org/r/20210526025625.601023-1-swboyd@chromium.org): * Fixed up Fixes tag on first first patch * Picked up acks * Moved decl of no_hash_pointers() to kernel.h
Changes from v1: * Dropped the hexdump printing format * Forced on the no_hash_pointers option instead of pushing %px
Joe Perches (1): slub: Indicate slab_fix() uses printf formats
Stephen Boyd (3): slub: Restore slub_debug=- behavior slub: Actually use 'message' in restore_bytes() slub: Force on no_hash_pointers when slub_debug is enabled
include/linux/kernel.h | 2 ++ lib/vsprintf.c | 2 +- mm/slub.c | 13 ++++++++++--- 3 files changed, 13 insertions(+), 4 deletions(-)
base-commit: d07f6ca923ea0927a1024dfccafc5b53b61cfecc -- https://chromeos.dev
| |