lkml.org 
[lkml]   [2021]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH v2 08/10] irqchip/gic-v3-its: Use irq_chip_ack_parent()
Date
On 27/05/21 13:17, Marc Zyngier wrote:
> On Tue, 25 May 2021 18:32:53 +0100,
> Valentin Schneider <valentin.schneider@arm.com> wrote:
>> o make irq_chip_ack_parent() the default chip->irq_ack() via
>> MSI_FLAG_USE_DEF_CHIP_OPS.
>
> Seem like a reasonable approach: how about a custom irq_ack() callback
> that iterates over the hierarchy until it finds an a non-NULL entry?
> Flows that don't use ack won't be impacted, users that need ack will
> provide one if they want, and the default will do something slightly
> slower, but at least unsurprising.
>

Sounds about right!

>> XXX: what about pMSI and fMSI ?
>
> Same thing. They are just bus-specific domains on top of the ITS
> domain, and must follow the same convention.
>
> However, this patch is perfectly acceptable to me (as long as you take
> care of platform and fsl -MSI).
>

Noted.

> Thanks,
>
> M.
>
> --
> Without deviation from the norm, progress is not possible.

\
 
 \ /
  Last update: 2021-06-01 12:26    [W:0.045 / U:2.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site