Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [RFC PATCH v2 02/10] genirq: Define irq_ack() and irq_eoi() helpers | Date | Tue, 01 Jun 2021 11:25:25 +0100 |
| |
On 27/05/21 11:58, Marc Zyngier wrote: > On Thu, 27 May 2021 11:55:50 +0100, > Marc Zyngier <maz@kernel.org> wrote: >> >> On Tue, 25 May 2021 18:32:47 +0100, >> Valentin Schneider <valentin.schneider@arm.com> wrote: >> > diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h >> > index b6c1cceddec0..090bd7868845 100644 >> > --- a/kernel/irq/internals.h >> > +++ b/kernel/irq/internals.h >> > @@ -87,6 +87,8 @@ extern void irq_enable(struct irq_desc *desc); >> > extern void irq_disable(struct irq_desc *desc); >> > extern void irq_percpu_enable(struct irq_desc *desc, unsigned int cpu); >> > extern void irq_percpu_disable(struct irq_desc *desc, unsigned int cpu); >> > +extern void irq_ack(struct irq_desc *desc); >> > +extern void irq_eoi(struct irq_desc *desc); >> >> Nit: we have {un,}mask_irq, but you add irq_{ack,eoi}. It'd be good to >> have some naming consistency (yes, this may/will clash with existing >> code, but we can fix that as well). > > Actually, the helpers do have the right naming, but the internal > declarations are the ones that are wrong... >
Doh!
> M. > > -- > Without deviation from the norm, progress is not possible.
| |