lkml.org 
[lkml]   [2021]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRE: [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest()
    Date

    [Don't see this on intel-gfx so I have to reply with top post.]

    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

    Regards,

    Tvrtko

    -----Original Message-----
    From: Zhihao Cheng <chengzhihao1@huawei.com>
    Sent: Saturday, May 29, 2021 5:33 AM
    To: jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com; Vivi, Rodrigo <rodrigo.vivi@intel.com>; airlied@linux.ie; daniel@ffwll.ch; chris@chris-wilson.co.uk; Ursulin, Tvrtko <tvrtko.ursulin@intel.com>
    Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; chengzhihao1@huawei.com; yukuai3@huawei.com
    Subject: [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest()

    In case of error, the function live_context() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR().

    Fixes: 52c0fdb25c7c9 ("drm/i915: Replace global breadcrumbs ...")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
    ---
    drivers/gpu/drm/i915/selftests/i915_request.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
    index ee8e753d98ce..eae0abd614cb 100644
    --- a/drivers/gpu/drm/i915/selftests/i915_request.c
    +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
    @@ -1592,8 +1592,8 @@ static int live_breadcrumbs_smoketest(void *arg)

    for (n = 0; n < smoke[0].ncontexts; n++) {
    smoke[0].contexts[n] = live_context(i915, file);
    - if (!smoke[0].contexts[n]) {
    - ret = -ENOMEM;
    + if (IS_ERR(smoke[0].contexts[n])) {
    + ret = PTR_ERR(smoke[0].contexts[n]);
    goto out_contexts;
    }
    }
    --
    2.25.4
    \
     
     \ /
      Last update: 2021-06-01 11:20    [W:2.464 / U:0.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site