Messages in this thread | | | Date | Tue, 1 Jun 2021 09:56:51 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] sched/debug:fix stale comments of sched_debug |
| |
On Mon, May 31, 2021 at 07:05:22PM +0300, Andy Shevchenko wrote: > > >> --- a/lib/Kconfig.debug > > >> +++ b/lib/Kconfig.debug > > >> @@ -1166,7 +1166,7 @@ config SCHED_DEBUG > > >> depends on DEBUG_KERNEL && PROC_FS > > > > > > Are the dependencies correct? > > > > Based on your suggestion, I checked and it turned out that PROC_FS is not > > the correct dependency, but DEBUG_FS. > > I guess you missed something. > > > Shoud I change it to DEBUG_FS? > > Please, double check.
Thing is that proc_sched_show_task() still wants PROC_FS, i've not yet found a suitable debugfs based location for that.
And DEBUG_FS doesn't need a dependency; it has complete DEBUG_FS=n wrappers and will build fine. Arguably selecting SCHED_DEBUG without DEBUG_FS is daft, but it should work.
| |