Messages in this thread |  | | Subject | Re: [git pull] drm fixes round two for 5.13-rc1 | From | Guenter Roeck <> | Date | Sun, 9 May 2021 17:47:37 -0700 |
| |
On 5/9/21 2:08 PM, Linus Torvalds wrote: > On Sun, May 9, 2021 at 11:16 AM Dave Airlie <airlied@gmail.com> wrote: >> >> Bit later than usual, I queued them all up on Friday then promptly >> forgot to write the pull request email. This is mainly amdgpu fixes, >> with some radeon/msm/fbdev and one i915 gvt fix thrown in. > > Hmm. Gcc seems ok with this, but clang complains: >
Yeah, sorry, that was supposed to fix a problem, not replace it with another one. And, as you noticed, gcc didn't complain, so I didn't realize that I created a mess (and don't ask me why I put that __maybe_unused after 'struct' - no idea).
Guenter
> drivers/video/fbdev/core/fbmem.c:736:21: warning: attribute > declaration must precede definition [-Wignored-attributes] > static const struct __maybe_unused seq_operations proc_fb_seq_ops = { > ^ > > but I noticed it only after I had already pushed out the pull. > > I'm actually surprised that gcc accepted that horrid mess: putting > "__maybe_unused" between the "struct" and the struct name is very very > wrong. > > I fixed it up after the merge due to not noticing earlier.. > > Maybe the drm test robots should start testing with clang too? > > Linus >
|  |