lkml.org 
[lkml]   [2021]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V2] media: i2c: ov2659: Fix an error message
Hi Christophe,

Thank you for the patch.

On Wed, May 5, 2021 at 9:17 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> 'ret' is known to be 0 here and printing -ENODEV wouldn't be really
> helpful. So remove it from the error message.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> V2: Remove the Fixes tag. It doesn't really fix something, it just removes
> a useless information.
> Just remove ret. No need to add something else.
> ---
> drivers/media/i2c/ov2659.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Acked-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index 42f64175a6df..6bbbb94fdda4 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1368,8 +1368,7 @@ static int ov2659_detect(struct v4l2_subdev *sd)
> id = OV265X_ID(pid, ver);
> if (id != OV2659_ID) {
> dev_err(&client->dev,
> - "Sensor detection failed (%04X, %d)\n",
> - id, ret);
> + "Sensor detection failed (%04X)\n", id);
> ret = -ENODEV;
> } else {
> dev_info(&client->dev, "Found OV%04X sensor\n", id);
> --
> 2.30.2
>

\
 
 \ /
  Last update: 2021-05-08 14:55    [W:0.031 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site