Messages in this thread | | | Date | Thu, 6 May 2021 23:33:25 -0700 | From | Eric Biggers <> | Subject | Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency |
| |
On Sun, Apr 25, 2021 at 09:10:53AM +0800, Chao Yu wrote: > + if (!error && S_ISDIR(inode->i_mode) && f2fs_encrypted_file(inode) && > + f2fs_is_checkpointed_node(sbi, inode->i_ino)) > + f2fs_add_ino_entry(sbi, inode->i_ino, ENC_DIR_INO);
This will never be true, since S_ISDIR() and f2fs_encrypted_file() are logically contradictory (as f2fs_encrypted_file() only returns true when S_ISREG()).
How did you test this change?
- Eric
| |