lkml.org 
[lkml]   [2021]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] iio: bme680_i2c: Remove ACPI support
From
Date
On 5/7/21 2:31 AM, Jonathan Cameron wrote:
> On Wed, 5 May 2021 20:43:32 -0700
> Guenter Roeck <linux@roeck-us.net> wrote:
>
>> With CONFIG_ACPI=n and -Werror, 0-day reports:
>>
>> drivers/iio/chemical/bme680_i2c.c:46:36: error:
>> 'bme680_acpi_match' defined but not used
>>
>> Apparently BME0680 is not a valid ACPI ID. Remove it and with it
>> ACPI support from the bme680_i2c driver.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> A note for these is that I'll change the patch titles when applying.
> We aren't removing ACPI support from the drivers, we are simply
> removing the ACPI ID table entries. For most of these PRP0001 magic
> will work just fine with the OF table. That's probably the
> right way for small companies etc to use these in products without
> having to jump through the hoops of getting an ACPI ID.
>

Ok, no problem. I'll keep that in mind if I hit any others.

Thanks,
Guenter

\
 
 \ /
  Last update: 2021-05-07 15:35    [W:0.118 / U:3.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site