| Date | Fri, 07 May 2021 10:08:18 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH 15/42] PCI: aardvark: Change name of INTx irq_chip to advk-INT |
| |
On Thu, 06 May 2021 16:31:26 +0100, Pali Rohár <pali@kernel.org> wrote: > > This name is visible in /proc/interrupts file and for better reading it > should have at most 8 characters. Also there is no need to allocate this > name dynamically, since there is only one PCIe controller on Armada 37xx. > This aligns with how the MSI irq_chip in this driver names it's interrupt > ("advk-MSI").
And *because* the name is visible in /proc/interrupts, it has become an ABI, and cannot be changed anymore.
We had the exact same issue with Tegra this merge window as I accidentally changed "Tegra" to "tegra", resulting in userspace programs failing find stuff in /proc/interrupts.
Please keep the name as is, no matter how ugly it is.
Thanks,
M.
-- Without deviation from the norm, progress is not possible.
|