Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 6 May 2021 15:00:26 +0200 | Subject | Re: [PATCH 06/11] mmc: core: Prepare mmc_send_cxd_data() to be re-used for additional cmds |
| |
On Tue, May 4, 2021 at 6:12 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> * NOTE: void *buf, caller for the buf is required to use DMA-capable > * buffer or on-stack buffer (with some overhead in callee). > */ > -static int > -mmc_send_cxd_data(struct mmc_card *card, struct mmc_host *host, > - u32 opcode, void *buf, unsigned len) > +int mmc_send_adtc_data(struct mmc_card *card, struct mmc_host *host, u32 opcode, > + u32 args, void *buf, unsigned len)
Just a note here (the change is good)
When applying please add some kerneldoc above mmc_send_adtc_data() and expand the ADTC acronym and add some info explaining what it is maybe a small protocol ref or so, so readers of the code get an intuitive feeling for what this function does and what ADTC is.
Yours, Linus Walleijq
| |