Messages in this thread | | | Date | Thu, 6 May 2021 14:19:03 +0300 | From | Vladimir Oltean <> | Subject | Re: [RFC PATCH net-next v3 06/20] net: dsa: qca8k: handle error with qca8k_write operation |
| |
On Wed, May 05, 2021 at 02:47:25AM +0200, Ansuel Smith wrote: > On Wed, May 05, 2021 at 02:41:24AM +0200, Andrew Lunn wrote: > > dev_err() > > > > In general, always use dev_err(), dev_warn(), dev_info() etc, so we > > know which device returned an error. > > > > I notice that in the driver we use pr function so I assumed this was the > correct way to report errors with a dsa driver.
Nope.
| |