Messages in this thread | | | Date | Thu, 6 May 2021 11:27:36 +0100 | From | Catalin Marinas <> | Subject | Re: [PATCH V2] mm: Define default value for FIRST_USER_ADDRESS |
| |
On Fri, Apr 16, 2021 at 10:47:34AM +0530, Anshuman Khandual wrote: > Currently most platforms define FIRST_USER_ADDRESS as 0UL duplication the > same code all over. Instead just define a generic default value (i.e 0UL) > for FIRST_USER_ADDRESS and let the platforms override when required. This > makes it much cleaner with reduced code. > > The default FIRST_USER_ADDRESS here would be skipped in <linux/pgtable.h> > when the given platform overrides its value via <asm/pgtable.h>. > > Cc: Richard Henderson <rth@twiddle.net> > Cc: Vineet Gupta <vgupta@synopsys.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Guo Ren <guoren@kernel.org> > Cc: Brian Cain <bcain@codeaurora.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Michal Simek <monstr@monstr.eu> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Ley Foon Tan <ley.foon.tan@intel.com> > Cc: Jonas Bonn <jonas@southpole.se> > Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> > Cc: Stafford Horne <shorne@gmail.com> > Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Heiko Carstens <hca@linux.ibm.com> > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jeff Dike <jdike@addtoit.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Chris Zankel <chris@zankel.net> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> [...] > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 47027796c2f9..f6ab8b64967e 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -26,8 +26,6 @@ > > #define vmemmap ((struct page *)VMEMMAP_START - (memstart_addr >> PAGE_SHIFT)) > > -#define FIRST_USER_ADDRESS 0UL > - > #ifndef __ASSEMBLY__ > > #include <asm/cmpxchg.h>
For arm64:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
| |