lkml.org 
[lkml]   [2021]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] usb: xhci-mtk: use bitfield instead of bool
On Thu, May 06, 2021 at 02:31:14PM +0800, Chunfeng Yun wrote:
> Use bitfield instead of bool in struct
>
> Refer to coding-style.rst 17) Using bool:
> "If a structure has many true/false values, consider consolidating
> them into a bitfield with 1 bit members, or using an appropriate
> fixed width type, such as u8."
>
> Due to @has_ippc's default vaule is 0, no need set it again if fail
> to get ippc base address

Please split this change out into a separate patch, as it has nothing to
do with the "change to bitfield" change.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-05-06 09:38    [W:0.222 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site