Messages in this thread | | | Date | Thu, 6 May 2021 09:37:15 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 1/3] usb: xhci-mtk: use bitfield instead of bool |
| |
On Thu, May 06, 2021 at 02:31:14PM +0800, Chunfeng Yun wrote: > Use bitfield instead of bool in struct > > Refer to coding-style.rst 17) Using bool: > "If a structure has many true/false values, consider consolidating > them into a bitfield with 1 bit members, or using an appropriate > fixed width type, such as u8." > > Due to @has_ippc's default vaule is 0, no need set it again if fail > to get ippc base address
Please split this change out into a separate patch, as it has nothing to do with the "change to bitfield" change.
thanks,
greg k-h
| |