| Date | Wed, 5 May 2021 13:24:37 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 05/25] media: i2c: ccs-core: return the right error code at suspend |
| |
On Wed, 5 May 2021 11:41:55 +0200 Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
> If pm_runtime resume logic fails, return the error code > provided by it, instead of -EAGAIN, as, depending on what > caused it to fail, it may not be something that would be > recovered. > > Fixes: cbba45d43631 ("[media] smiapp: Use runtime PM") > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> --- > drivers/media/i2c/ccs/ccs-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c > index 9dc3f45da3dc..b05f409014b2 100644 > --- a/drivers/media/i2c/ccs/ccs-core.c > +++ b/drivers/media/i2c/ccs/ccs-core.c > @@ -3093,7 +3093,7 @@ static int __maybe_unused ccs_suspend(struct device *dev) > if (rval < 0) { > pm_runtime_put_noidle(dev); > > - return -EAGAIN; > + return rval; > } > > if (sensor->streaming)
|