Messages in this thread | | | Date | Wed, 5 May 2021 20:14:18 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 5.11 036/104] KVM: arm64: Use BUG and BUG_ON in nVHE hyp |
| |
On Wed, May 05, 2021 at 05:48:51PM +0100, Marc Zyngier wrote: >Sasha, > >On Wed, 05 May 2021 17:33:05 +0100, >Sasha Levin <sashal@kernel.org> wrote: >> >> From: Andrew Scull <ascull@google.com> >> >> [ Upstream commit f79e616f27ab6cd74deb0995a8eead3d1c9d65af ] >> >> hyp_panic() reports the address of the panic by using ELR_EL2, but this >> isn't a useful address when hyp_panic() is called directly. Replace such >> direct calls with BUG() and BUG_ON() which use BRK to trigger an >> exception that then goes to hyp_panic() with the correct address. Also >> remove the hyp_panic() declaration from the header file to avoid >> accidental misuse. >> >> Signed-off-by: Andrew Scull <ascull@google.com> >> Acked-by: Will Deacon <will@kernel.org> >> Signed-off-by: Marc Zyngier <maz@kernel.org> >> Link: https://lore.kernel.org/r/20210318143311.839894-5-ascull@google.com >> Signed-off-by: Sasha Levin <sashal@kernel.org> > >This has no chance of working without the patches that enable BUG() >support at EL2, and *really* isn't stable material. > >Please drop this patch.
Will do, thanks!
-- Thanks, Sasha
| |