Messages in this thread |  | | From | Mauri Sandberg <> | Date | Sun, 30 May 2021 22:02:35 +0300 | Subject | Re: [PATCH v4 2/2] gpio: gpio-mux-input: add generic gpio input multiplexer |
| |
On 30.5.2021 21.09, Andy Shevchenko wrote: > On Sun, May 30, 2021 at 7:16 PM Mauri Sandberg <maukka@ext.kapsi.fi> wrote: >> Adds support for a generic GPIO multiplexer. To drive the multiplexer a >> mux-controller is needed. The output pin of the multiplexer is a GPIO >> pin. >> >> Reported-by: kernel test robot <lkp@intel.com> > Is it a fix? Shall we add the Fixes tag?
In the v1 a build bot complained about .owner along these lines:
--- snip ---- If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
cocci warnings: (new ones prefixed by >>) >> drivers/gpio/gpio-mux-input.c:138:3-8: No need to set .owner here. The core will do it.
Please review and possibly fold the followup patch. --- snip ---
I removed the .owner attribute in v2 as requested but wasn't really sure whether it was "appropriate" to add the tag so I put it there anyhow. Technically, this does not fix any previous commit.
>> Signed-off-by: Mauri Sandberg <maukka@ext.kapsi.fi> >> Tested-by: Drew Fustini <drew@beagleboard.org> >> Reviewed-by: Drew Fustini <drew@beagleboard.org> >
|  |