lkml.org 
[lkml]   [2021]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 02/28] leds: core: The -ENOTSUPP should never be seen by user space
On Fri, May 28, 2021 at 1:43 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, May 28, 2021 at 12:03:39PM +0200, Pavel Machek wrote:
> > On Mon 2021-05-10 12:50:19, Andy Shevchenko wrote:
> > > Replace -ENOTSUPP by -EOPNOTSUPP when returning from exported function.
> > >
> > > Fixes: 13ae79bbe4c2 ("leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting")
> > > Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> > > Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> >
> > Are you sure this is real problem?
>
> (Potential) real problem, yes.
>
> » This does not sound like an error
> > path that should happen.
>
> Before crafting this patch I have checked callers and _luckily_ they haven't
> tested the returned code. But if any of the user decides to check -> real
> problem.

I have rephrased the commit message to point out the above.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-05-29 11:43    [W:0.073 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site