lkml.org 
[lkml]   [2021]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] wireless: carl9170: fix LEDS build errors & warnings
On Sat, May 29, 2021 at 9:16 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> kernel test robot reports over 200 build errors and warnings
> that are due to this Kconfig problem when CARL9170=m,
> MAC80211=y, and LEDS_CLASS=m.

I think this avoids the build problems, but it's not really logical:

> --- linux-next-20210528.orig/drivers/net/wireless/ath/carl9170/Kconfig
> +++ linux-next-20210528/drivers/net/wireless/ath/carl9170/Kconfig
> @@ -17,9 +17,7 @@ config CARL9170
> config CARL9170_LEDS
> bool "SoftLED Support"
> depends on CARL9170
> - select MAC80211_LEDS
> - select LEDS_CLASS
> - select NEW_LEDS
> + select MAC80211_LEDS if LEDS_CLASS=y || LEDS_CLASS=MAC80211
> default y
> help
> This option is necessary, if you want your device' LEDs to blink

The point of the option is to enable LED support, but now it doesn't do that
when LEDS_CLASS is a loadable module and MAC80211 is built-in.

I think a more sensible solution would be to follow the example of

config MT76_LEDS
bool
depends on MT76_CORE
depends on LEDS_CLASS=y || MT76_CORE=LEDS_CLASS
default y

Arnd

\
 
 \ /
  Last update: 2022-09-17 16:10    [W:0.047 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site