Messages in this thread Patch in this message |  | | From | Liam Beguin <> | Subject | [PATCH v1 2/9] iio: inkern: error out on unsupported offset type | Date | Sat, 29 May 2021 20:59:10 -0400 |
| |
From: Liam Beguin <lvb@xiphos.com>
iio_convert_raw_to_processed_unlocked() assumes the offset is an integer. Make that clear to the consumer by returning an error when an unsupported offset type is detected.
Signed-off-by: Liam Beguin <lvb@xiphos.com> --- drivers/iio/inkern.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c index 4b6a8e11116a..dede4536d499 100644 --- a/drivers/iio/inkern.c +++ b/drivers/iio/inkern.c @@ -595,8 +595,12 @@ static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan, int ret; ret = iio_channel_read(chan, &offset, NULL, IIO_CHAN_INFO_OFFSET); - if (ret >= 0) + if (ret == IIO_VAL_INT) { raw64 += offset; + } else if (ret >= 0) { + dev_err(&chan->indio_dev->dev, "unsupported offset type"); + return -EINVAL; + } scale_type = iio_channel_read(chan, &scale_val, &scale_val2, IIO_CHAN_INFO_SCALE); -- 2.30.1.489.g328c10930387
|  |