Messages in this thread | | | Date | Fri, 28 May 2021 08:29:33 +0200 | From | Michael Walle <> | Subject | Re: [PATCH v3 5/6] pinctrl: Add RTL8231 pin control and GPIO support |
| |
> + gpio_cfg.reg_dat_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DATA0); > + gpio_cfg.reg_set_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DATA0); > + gpio_cfg.reg_dir_in_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DIR0);
Btw. you'd only need GPIO_REGMAP_ADDR(x) if x might be 0. Because you have a constant != 0 there, you could save the GPIO_REGMAP_ADDR() call. You could drop this if you like, but no need to respin the series for this.
-michael
| |