lkml.org 
[lkml]   [2021]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 08/28] leds: lgm-sso: Put fwnode in any case during ->probe()
    Hi!

    > @@ -734,10 +736,15 @@ static int sso_led_dt_parse(struct sso_led_priv *priv)
    > if (fw_ssoled) {
    > ret = __sso_led_dt_parse(priv, fw_ssoled);
    > if (ret)
    > - return ret;
    > + goto err_child_out;
    > }
    >
    > + fwnode_handle_put(fw_ssoled);
    > return 0;
    > +
    > +err_child_out:
    > + fwnode_handle_put(fw_ssoled);
    > + return ret;
    > }

    Just delete the return and you get the same effect, no? No need to
    have two exits here.

    BR,
    Pavel
    --
    http://www.livejournal.com/~pavelmachek
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-05-28 12:09    [W:3.461 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site