Messages in this thread | | | Date | Fri, 28 May 2021 12:34:26 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/6] i2c: acpi: Export i2c_acpi_find_client_by_adev() for users |
| |
On Fri, May 28, 2021 at 11:25:51AM +0200, Greg Kroah-Hartman wrote: > On Thu, May 27, 2021 at 10:26:33PM +0200, Wolfram Sang wrote: > > On Wed, May 26, 2021 at 03:43:17PM +0300, Andy Shevchenko wrote: > > > There is at least one user that will gain from the > > > i2c_acpi_find_client_by_adev() being exported. > > > > No objections per se. But as the user is in staging, I want to ask if > > the use there is really a solution we would also accept outside of > > staging? Or is it a hack? > > staging drivers should be self-contained, do not accept code in the core > kernel that only is used by staging drivers. > > So I would not recommend this be accepted at this point in time.
Fair enough.
> Andy, work to get the driver out of staging first before doing stuff > like this.
Okay, I'll drop first one and patches related to it in the v2. It should bring us closer to the mentioned point.
Thanks for clarification!
-- With Best Regards, Andy Shevchenko
| |