lkml.org 
[lkml]   [2021]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/2] writeback, cgroup: release dying cgwbs by switching attached inodes
On Thu, May 27, 2021 at 11:24:59AM +0800, Hillf Danton wrote:
> On Wed, 26 May 2021 15:25:57 -0700 Roman Gushchin wrote:
> >+
> >+ if (!list_empty(&offline_cgwbs))
> >+ schedule_work(&cleanup_offline_cgwbs_work);
> >+
>
> Good work overall.

Thanks!

>
> Nit, given cond_resched_lock() in cleanup_offline_wb(), what you need instead
> is
> queue_work(system_unbound_wq, &cleanup_offline_cgwbs_work);

Neat, will do in the next version.

Thanks!

\
 
 \ /
  Last update: 2021-05-27 18:31    [W:0.133 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site