Messages in this thread | | | Date | Thu, 27 May 2021 09:29:56 -0700 | From | Roman Gushchin <> | Subject | Re: [PATCH v5 2/2] writeback, cgroup: release dying cgwbs by switching attached inodes |
| |
On Thu, May 27, 2021 at 11:24:59AM +0800, Hillf Danton wrote: > On Wed, 26 May 2021 15:25:57 -0700 Roman Gushchin wrote: > >+ > >+ if (!list_empty(&offline_cgwbs)) > >+ schedule_work(&cleanup_offline_cgwbs_work); > >+ > > Good work overall.
Thanks!
> > Nit, given cond_resched_lock() in cleanup_offline_wb(), what you need instead > is > queue_work(system_unbound_wq, &cleanup_offline_cgwbs_work);
Neat, will do in the next version.
Thanks!
| |